feat: support Secp256k1 format private keys import #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j75689
changed the title
unclezoro
approved these changes
Nov 2, 2023
unclezoro
reviewed
Nov 2, 2023
client/keys/import.go
Outdated
| Short: "Import private keys into the local keybase", | ||
| Long: "Import a ASCII armored private key into the local keybase.", | ||
| Long: "Import a ASCII armored/EIP-712 private key into the local keybase.", |
There was a problem hiding this comment.
I think EIP-712 can not describe a kind of private key
unclezoro
requested changes
Nov 2, 2023
j75689
changed the title
unclezoro
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: support Secp256k1 private keys import
Rationale
support Secp256k1 format private keys import via cmd
Example
Changes
Notable changes: